[PERF]: remove mutex around tokenizer #2735
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Saves around 1,300ms when ingesting 15k documents (averaging 1000 chars each).
We spend 1.5x the tokenization time just cloning the tokens, which should be avoidable but is not included in this PR because the lifetimes get hairy and the % that tokenization takes in the total compaction time is currently fairly low.
Summarize the changes made by this PR.
Box
wrapperTest plan
How are these changes tested?
Covered by existing tests.
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
n/a