Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Update to async'ified, limited client. #3399

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Jan 3, 2025

The client would open an unbounded number of connections. Bound it so
that they will only open so many connections at once.

rescrv added 2 commits January 3, 2025 08:07
The client would open an unbounded number of connections.  Bound it so
that they will only open so many connections at once.
Copy link

github-actions bot commented Jan 3, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Base automatically changed from rescrv/chroma-load-do-not-log-429 to main January 3, 2025 16:43
@rescrv rescrv merged commit cd61136 into main Jan 3, 2025
79 checks passed
@rescrv rescrv deleted the rescrv/chroma-load-dropped-notify branch January 3, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant