-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: v2 refactoring to use feed byte identifier #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmerkleplant
force-pushed
the
v2_feed_byte_identifier
branch
from
September 29, 2023 09:12
6d0e56d
to
ae2e83d
Compare
Force pushed to rebase to v1.2.0. |
pmerkleplant
force-pushed
the
v2_feed_byte_identifier
branch
from
October 17, 2023 08:52
c6de25b
to
5254653
Compare
pmerkleplant
force-pushed
the
v2_feed_byte_identifier
branch
from
November 2, 2023 12:11
0bc6f44
to
2ee1716
Compare
Force push to rebase to current |
all: v2 refactoring to use feed byte identifier
🚨 Vulnerabilities Summary
For more details view the full report in OpenZeppelin Code |
The fix allows the removal of LibSchnorrData and LibBytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors Scribe to use the first byte of a feed's address as their identifier instead of a "random" storage index. This allows backend systems to not have to know an instance's internal state in order to create the
IScribe.SchnorrData
payload.Breaking Changes:
IScribe.SchnorrData.signersBlob
got renamed toIScribe.SchnorrData.feedIds
IScribe
'sSignerNotFeed(address signer)
renamed toerror InvalidFeedId(uint8 feedId)
IScribe
'sSignersNotOrdered()
renamed toerror DoubleSigningAttempted(uint8 feedId);
FeedLifted
andFeedDropped
events updated to emit the feed's id instead of their indexmaxFeeds()(uint8)
. The maximum number of supported feeds istype(uint8).max + 1
feeds
read and management functions updated to take/return feed ids instead of indexeslift
anddrop
function updated to take/return feed ids instead of indexesIScribeOptimistic::opFeedIndex()
updated toopFeedId()
This PR shall only be merged once the changes are audited!