Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test.yml set MSRV for test #1350

Closed
wants to merge 2 commits into from

Conversation

jtmoon79
Copy link
Contributor

@jtmoon79 jtmoon79 commented Nov 4, 2023

Previously, the MSRV 1.57.0 was not actually being used to run the cargo test, the default rust was used (currently at 1.70.0).

Thanks for contributing to chrono!

If your feature is semver-compatible, please target the 0.4.x branch;
the main branch will be used for 0.5.0 development going forward.

Please consider adding a test to ensure your bug fix/feature will not break in the future.

Previously, the MSRV 1.57.0 was not actually being used
to run the `cargo test`, the default rust was used (currently
at 1.70.0).
Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Merging #1350 (3477c13) into 0.4.x (15c8885) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            0.4.x    #1350   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files          38       38           
  Lines       17482    17482           
=======================================
  Hits        16016    16016           
  Misses       1466     1466           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@jtmoon79 jtmoon79 closed this Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant