Fix chromium links #209
Merged
Fix chromium links #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninelore
approved these changes
Oct 3, 2024
Owen-sz
force-pushed
the
chromium-links-fix
branch
from
a6468bc to
0b1008f
Compare
Should be good now |
ninelore
requested changes
Oct 4, 2024
|
Can second ninelore. This has to do with the device property (list of device names) PR is very difficult to review with the change in spacing, since it shows every line has changed. If possible, could we restore 4 spacing or use 2 separate commits |
Owen-sz
force-pushed
the
chromium-links-fix
branch
from
0b1008f to
839ae2e
Compare
|
Fixed it |
ethanaobrien
approved these changes
Oct 5, 2024
|
We have local image links that are 404. ToDo check where they went |
Which images? |
|
I don't know where the Chromium images went, not seeing anything about it. |
|
I will investigate it soon dw |
ninelore
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Chromium docs links in devices.json give 404, as the upstream links seemed to have changed. These are the proper links.