Cleanup config parsing and database migration errors #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskchanky
reviewed
May 22, 2018
| @@ -18,5 +18,5 @@ func Migrate(db *sql.DB, migrations_dir string) { | |||
| m, err := migrate.NewWithDatabaseInstance( | |||
| fmt.Sprintf("file://%s", migrations_dir), | |||
| "postgres", driver) | |||
| m.Up() | |||
| m.Steps(0) | |||
There was a problem hiding this comment.
Why Steps(0) here, but Up() below in sessionsrv?
raskchanky
reviewed
May 22, 2018
components/originsrv/cmd/root.go
Outdated
| @@ -70,8 +70,8 @@ func initConfig() { | |||
| } | |||
|
|
|||
| // DBConfigFromViper fetches database config from viper | |||
There was a problem hiding this comment.
This comment is wrong now, given the function name change.
raskchanky
approved these changes
May 22, 2018
The long and the short of this is there were multiple errors with parsing configs and running migrations. What you need to know: There is a patched vendor file (shame on me, I know). However, being the nice netizen that I am, I made a PR upstream golang-migrate/migrate#36 The other stuff is mostly cleanup around how viper serializes config files and some bad quoting on my part in originsrv. Signed-off-by: Elliott Davis <[email protected]>
elliott-davis
force-pushed
the
elliott/cleanupening
branch
from
70943cf to
d4d1efc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The long and the short of this is there were multiple errors with parsing configs and running migrations.
What you need to know:
There is a patched vendor file (shame on me, I know). However, being the nice netizen that I am, I made a PR upstream golang-migrate/migrate#36
The other stuff is mostly cleanup around how viper serializes config files and some bad quoting on my part in originsrv.
Signed-off-by: Elliott Davis [email protected]