Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dot net tool packaging path #434

Closed
wants to merge 1 commit into from

Conversation

bptillman
Copy link

@bptillman bptillman commented Jul 6, 2021

Currently this bug is open where the latest dotnet tool install for Roundhouse does not currently work due to it not finding the DotNetToolSettings.xml file. This was due to a change with the file path in the tool nuspec file where backslashes were swapped for forward slashes, which led to the directory structure of the tool package changing and nesting files deeper inside the structure of the package. As you can see in the below screenshot, changing the forward slashes to a backslashes restores the directory structure where the contents can be found under the tools\.netcoreapp2.1\any\ folder (on the right) instead of under tools\netcoreapp2.1\any\bin\netcoreapp2.1\publish (on the left). With this new directory structure, the DotNetToolSettings.xml file can be found directly under the any folder now, which should alleviate the error currently being seen.

image

I tested this change in both Windows where I originally made the change and in Ubuntu in WSL and the dotnet tool package appeared to build correctly in both systems.

I reviewed the contributor guidelines and did not see any other modifications I should make with this change, but if there is anything more I should do as a part of this fix, please let me know.

@bptillman bptillman changed the title Fix dot net tool packing path Fix dot net tool packaging path Jul 6, 2021
@bptillman
Copy link
Author

@erikbra I wanted to see if there was anything I could do to help with getting this one merged? Myself and a few others at my org Headspring are interested in becoming contributors/maintainers if that's a possibility?

@bptillman
Copy link
Author

@ferventcoder is there any assistance you could provide in helping get this merged with a new release for Roundhouse? Additionally, do you have any interest in adding additional maintainers? Myself and some others at Headspring are interested in helping further along Roundhouse since it is our DB migration tool of choice, if you are open to that.

@erikbra
Copy link
Member

erikbra commented Sep 12, 2021

@bptillman terribly for the lack of feedback here. You should definitely not have to wait this long for feedback on a PR.

That said, I do thinkg release 1.3.0 solved the issue, although in another way. Could you please confirm whether it works or not?

Regarding maintainers, help is definitely wanted. I took on a maintainer role, but haven't been able to follow up as much as I feel like. I do have some different options going forward, though, as RoundhousE does suffer from a lot of legacy dependencies, which makes upgrading to more current .NET versions difficult. Happy to have a chat about it, if you are interested!

@bptillman
Copy link
Author

@erikbra I was able to confirm that 1.3.0, and now the latest 1.3.1, both appear to address this issue so I will close the PR. Thanks for fixing the issue.

As far as maintainers go, should I reach out to you via email or some other medium for further discussion on this?

@erikbra
Copy link
Member

erikbra commented Sep 14, 2021

Great to hear that the problem is fixed in the latest version, @bptillman! With regards to contribution, please have a look at issue #438 . Would you be interested in helping out on my new project, reimplementing RoundhousE (or, a very similar tool), from scratch (it's well underway, don't worry).

@erikbra
Copy link
Member

erikbra commented Sep 14, 2021

I'll just close it, according to your comment

@erikbra erikbra closed this Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants