Handle data tables #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 18, 2016 15:36
If a row doesn't respond to scenario_outline, assume it is a data table rather than an example table for a scenario outline. It doesn't make sense to create a test case for a row in a data table.
The main reason for this addition is to consolidate calls to instance_of? into a method that can be easily stubbed, since mock objects won't play nicely with instance_of?
Only create a TestCase if we are in a Scenario. Steps in a ScenarioOutline don't by themselves define a TestCase to be executed, timed, and reported. Not until we get to the example rows will we want to do that.
|
This is great, thank you! I'm a bit swamped for the next week or so helping with a conference, but please feel free to ping me if I let this sit for too long! |
|
So after writing this I discovered that cucumber actually has a built-in junit formatter which does what I was attempting to add here. Wondering whether there is still a reason to use ci_reporter_cucumber given that alternative. In any case, I hope this addition is useful to somebody :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci_reporter_cucumber was not distinguishing between data tables and tables of examples. The latter should be processed as individual test cases while the former should not.
This update adds that feature.