Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template for max value of QoI within simulated time #561

Merged
merged 6 commits into from
Apr 3, 2024

Conversation

anirban-chaudhuri
Copy link
Contributor

@anirban-chaudhuri anirban-chaudhuri commented Apr 3, 2024

  • Adds template for QoI callable function for extracting the maximum value of a state within the simulated time range.
  • Template added to qoi.py

@anirban-chaudhuri anirban-chaudhuri added the integration Tasks for integration with TA4 label Apr 3, 2024
@anirban-chaudhuri anirban-chaudhuri self-assigned this Apr 3, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@SamWitty
Copy link
Contributor

SamWitty commented Apr 3, 2024

@anirban-chaudhuri , can you add a description and a simple test? Thanks!

@anirban-chaudhuri
Copy link
Contributor Author

@anirban-chaudhuri , can you add a description and a simple test? Thanks!

I added a description and also added the new template to the tests.

@SamWitty SamWitty merged commit 8283eca into main Apr 3, 2024
5 checks passed
@anirban-chaudhuri anirban-chaudhuri deleted the ac-opt-maxvalueQoI branch April 3, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration Tasks for integration with TA4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add template for max value of a state in the simulated time range as QoI in optimize
2 participants