connectivity: Misc enc test case changes #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
force-pushed
the
pr/brb/conn-enc-improvements
branch
from
639bbda to
8b5a580
Compare
brb
force-pushed
the
pr/brb/conn-enc-improvements
branch
from
8b5a580 to
03246d7
Compare
brb
changed the title
meyskens
reviewed
Oct 19, 2023
giorio94
reviewed
Oct 20, 2023
connectivity/tests/encryption.go
Outdated
| // a packet to the tunnel netdev, and only afterwards redirects to the WG netdev | ||
| // for the encryption. | ||
| func getInterNodeIface(ctx context.Context, t *check.Test, | ||
| client, clientHost, server, serverHost *check.Pod, ipFam features.IPFamily) string { |
There was a problem hiding this comment.
Nit. I wonder if it could make sense to rename client and server to source and destination for additional clarity, given that this function is used to determine the interface on both sides, with swapped parameters.
There was a problem hiding this comment.
I will do that in a separate PR!
| func getFilter(ctx context.Context, t *check.Test, client, clientHost *check.Pod, | ||
| server, serverHost *check.Pod, |
There was a problem hiding this comment.
Same here about the possibility of renaming client and server to source and destination for additional clarity.
connectivity/tests/encryption.go
Outdated
Comment on lines
128
to
126
| if enc, ok := t.Context().Feature(features.EncryptionPod); tunnelEnabled && ok && | ||
| enc.Enabled && enc.Mode == "wireguard" { |
There was a problem hiding this comment.
I guess that the version compatibility check would be appropriate also here.
brb
force-pushed
the
pr/brb/conn-enc-improvements
branch
from
49d7775 to
b3e5158
Compare
brb
force-pushed
the
pr/brb/conn-enc-improvements
branch
from
b3e5158 to
c7b7ce7
Compare
An upcoming commit will move the whole tcpdump filter derivation into the function. Signed-off-by: Martynas Pumputis <[email protected]>
Instead of modifying the src filter. A subsequent commit will move the filter derivation logic into getFilter. Signed-off-by: Martynas Pumputis <[email protected]>
Signed-off-by: Martynas Pumputis <[email protected]>
Signed-off-by: Martynas Pumputis <[email protected]>
As the iface derivation now might depend on the src/dst host IP, pass both host pods to testNoTrafficLeak() invocations in the node-to-node test case. Signed-off-by: Martynas Pumputis <[email protected]>
Unfortunately, this makes the inverse tests (assertNoLeaks=false) noop for this special case. But an additional check for leaks is going to be added outside the CLI. Signed-off-by: Martynas Pumputis <[email protected]>
brb
force-pushed
the
pr/brb/conn-enc-improvements
branch
from
c7b7ce7 to
ce1da30
Compare
brb
force-pushed
the
pr/brb/conn-enc-improvements
branch
from
ce1da30 to
3e4fb5c
Compare
brb
force-pushed
the
pr/brb/conn-enc-improvements
branch
from
3e4fb5c to
7f47895
Compare
brb
force-pushed
the
pr/brb/conn-enc-improvements
branch
from
7f47895 to
23556b9
Compare
mhofstetter
reviewed
Nov 1, 2023
Signed-off-by: Martynas Pumputis <[email protected]>
brb
force-pushed
the
pr/brb/conn-enc-improvements
branch
from
23556b9 to
888883f
Compare
brb
added
ready-to-merge
brb
added a commit
to cilium/cilium
that referenced
this pull request
Nov 6, 2023
Also, bump the CLI to include those tests [1]. [1]: cilium/cilium-cli#2055 Signed-off-by: Martynas Pumputis <[email protected]>
brb
added a commit
to cilium/cilium
that referenced
this pull request
Nov 6, 2023
To include the encryption suite changes [1]. [1]: cilium/cilium-cli#2055 Signed-off-by: Martynas Pumputis <[email protected]>
brb
added a commit
to cilium/cilium
that referenced
this pull request
Nov 6, 2023
To include the encryption suite changes [1]. [1]: cilium/cilium-cli#2055 Signed-off-by: Martynas Pumputis <[email protected]>
brb
added a commit
to cilium/cilium
that referenced
this pull request
Nov 6, 2023
To include the encryption suite changes [1]. [1]: cilium/cilium-cli#2055 Signed-off-by: Martynas Pumputis <[email protected]>
brb
added a commit
to cilium/cilium
that referenced
this pull request
Nov 6, 2023
To include the encryption suite changes [1]. [1]: cilium/cilium-cli#2055 Signed-off-by: Martynas Pumputis <[email protected]>
brb
added a commit
to cilium/cilium
that referenced
this pull request
Nov 6, 2023
Also, bump the CLI to include those tests [1]. [1]: cilium/cilium-cli#2055 Signed-off-by: Martynas Pumputis <[email protected]>
brb
added a commit
to cilium/cilium
that referenced
this pull request
Nov 7, 2023
To include the encryption suite changes [1] [2] [1]: cilium/cilium-cli#2055 [2]: cilium/cilium-cli#2089 Signed-off-by: Martynas Pumputis <[email protected]>
aanm
pushed a commit
to cilium/cilium
that referenced
this pull request
Nov 7, 2023
To include the encryption suite changes [1] [2] [1]: cilium/cilium-cli#2055 [2]: cilium/cilium-cli#2089 Signed-off-by: Martynas Pumputis <[email protected]>
pjablonski123
pushed a commit
to pjablonski123/cilium
that referenced
this pull request
Dec 15, 2023
To include the encryption suite changes [1] [2] [1]: cilium/cilium-cli#2055 [2]: cilium/cilium-cli#2089 Signed-off-by: Martynas Pumputis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.