Skip to content

Commit

Permalink
Remove Dockerfile
Browse files Browse the repository at this point in the history
Hubble CLI binary already gets shipped as a part of the Cilium Agent
image, so let's not maintain yet another image.

- Remove Dockerfile and build-images-release.yaml.
- Put release.yml in the release GitHub environment.

Signed-off-by: Michi Mutsuzaki <[email protected]>
  • Loading branch information
michi-covalent committed Dec 10, 2024
1 parent 1b7b2f8 commit 6456408
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 176 deletions.
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/release.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ title: 'vX.Y.Z release'
git push origin "v$NEW_RELEASE"

- [ ] Ping [`hubble-maintainers` team] on Slack to get an approval to run
[Image Release Build workflow].
[Release workflow].
- [ ] Wait for the [`Create a release` workflow] to finish.
- [ ] Find the release draft in the [Releases page]. Copy and paste release notes from
CHANGELOG.md, and click on `Publish release` button.
Expand All @@ -95,7 +95,7 @@ title: 'vX.Y.Z release'
and then open a pull request against the `main` branch, get it reviewed and merged.

[Cilium release tool]: https://github.com/cilium/release
[Image Release Build workflow]: https://github.com/cilium/hubble/actions/workflows/build-images-release.yaml
[Release workflow]: https://github.com/cilium/hubble/actions/workflows/release.yml
[`hubble-maintainers` team]: https://github.com/orgs/cilium/teams/hubble-maintainers
[Releases page]: https://github.com/cilium/hubble/releases
[Cilium Slack #general channel]: https://cilium.slack.com/archives/C1MATJ5U5
Expand Down
1 change: 0 additions & 1 deletion .github/renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
"gitAuthor": "renovate[bot] <[email protected]>",
"includePaths": [
".github/workflows/**",
"Dockerfile",
"go.mod",
"go.sum",
"Makefile",
Expand Down
155 changes: 0 additions & 155 deletions .github/workflows/build-images-release.yaml

This file was deleted.

1 change: 1 addition & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ name: Create a release
jobs:
build:
name: Create Release
environment: release
if: github.repository == 'cilium/hubble'
runs-on: ubuntu-24.04
steps:
Expand Down
18 changes: 0 additions & 18 deletions Dockerfile

This file was deleted.

0 comments on commit 6456408

Please sign in to comment.