Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envoy: Enable all extensions #987

Closed
wants to merge 1 commit into from
Closed

envoy: Enable all extensions #987

wants to merge 1 commit into from

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Oct 26, 2024

Just wanna check the build time and also binary size, the current binary is around ~55MB.

New build is taking almost same time (~10 mins), probably due to caching, but the binary size is increasing to 68M

root@75e5b8c73034:/# ls -lrth /usr/bin/cilium-envoy
-rwxr-xr-x 1 1337 1337 68M Oct 26 15:03 /usr/bin/cilium-envoy

Signed-off-by: Tam Mach <[email protected]>
@sayboras sayboras force-pushed the pr/tammach/build-all branch from 8d17dff to c8c80d7 Compare October 26, 2024 14:54
@jrajahalme
Copy link
Member

Might as well do this then? I guess the biggest build time penalty was from WASM that is already enabled?

@sayboras sayboras marked this pull request as ready for review October 31, 2024 09:51
@sayboras sayboras requested a review from a team as a code owner October 31, 2024 09:51
@sayboras sayboras requested review from jrajahalme and removed request for a team October 31, 2024 09:51
@sayboras sayboras changed the title Enable all extensions envoy: Enable all extensions Oct 31, 2024
@sayboras sayboras marked this pull request as draft October 31, 2024 13:14
@sayboras sayboras added the dont-merge/preview-only DON'T MERGE label Nov 28, 2024
@sayboras sayboras closed this Dec 11, 2024
@sayboras sayboras deleted the pr/tammach/build-all branch December 11, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants