Remove tetragon_errors_total{type="handler_error"} metric

It was duplicating tetragon_handler_errors_total. Signed-off-by: Anna Kapuscinska <[email protected]>
cilium · Sep 2, 2024 · 4032590 · 4032590
1 parent 15ae54a
commit 4032590
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 6 deletions.
diff --git a/contrib/upgrade-notes/latest.md b/contrib/upgrade-notes/latest.md
@@ -62,3 +62,4 @@ tetragon:
 * `tetragon_event_cache_retries_total` metric is renamed to `tetragon_event_cache_fetch_retries_total`.
 * `tetragon_errors_total{type="event_missing_process_info"}` metric is replaced by
   `tetragon_events_missing_process_info_total`.
+* `tetragon_errors_total{type="handler_error"}` metric is removed. Use `tetragon_handler_errors_total` instead.
diff --git a/docs/content/en/docs/reference/metrics.md b/docs/content/en/docs/reference/metrics.md
diff --git a/pkg/metrics/errormetrics/errormetrics.go b/pkg/metrics/errormetrics/errormetrics.go
@@ -17,8 +17,6 @@ type ErrorType int
 const (
 	// Tid and Pid mismatch that could affect BPF and user space caching logic
 	ProcessPidTidMismatch ErrorType = iota
-	// An error occurred in an event handler.
-	HandlerError
 	// An event finalizer on Process failed
 	EventFinalizeProcessInfoFailed
 	// Failed to resolve Process uid to username
@@ -30,7 +28,6 @@ const (
 
 var errorTypeLabelValues = map[ErrorType]string{
 	ProcessPidTidMismatch:                   "process_pid_tid_mismatch",
-	HandlerError:                            "handler_error",
 	EventFinalizeProcessInfoFailed:          "event_finalize_process_info_failed",
 	ProcessMetadataUsernameFailed:           "process_metadata_username_failed",
 	ProcessMetadataUsernameIgnoredNotInHost: "process_metadata_username_ignored_not_in_host_namespaces",

diff --git a/pkg/observer/observer.go b/pkg/observer/observer.go
@@ -124,8 +124,6 @@ func (k *Observer) receiveEvent(data []byte) {
 	op, events, err := HandlePerfData(data)
 	opcodemetrics.OpTotalInc(ops.OpCode(op))
 	if err != nil {
-		// Increment error metrics
-		errormetrics.ErrorTotalInc(errormetrics.HandlerError)
 		errormetrics.HandlerErrorsInc(ops.OpCode(op), err.kind)
 		switch err.kind {
 		case errormetrics.HandlePerfUnknownOp: