errmetrics: refactor

Signed-off-by: Kornilios Kourtis <[email protected]>
cilium · Dec 12, 2024 · ffc4f82 · ffc4f82
1 parent 7dbd046
commit ffc4f82
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/pkg/errmetrics/errmetrics.go b/pkg/errmetrics/errmetrics.go
@@ -22,7 +22,7 @@ type Entry struct {
 //go:embed fileids.json
 var fileIDsJSON []byte
 
-var getFileIDs = sync.OnceValues(func() (map[int]string, error) {
+var GetFileIDs = sync.OnceValues(func() (map[int]string, error) {
 	var entries []Entry
 	if err := json.Unmarshal(fileIDsJSON, &entries); err != nil {
 		return nil, err

diff --git a/pkg/errmetrics/map.go b/pkg/errmetrics/map.go
@@ -11,6 +11,8 @@ import (
 	"golang.org/x/sys/unix"
 )
 
+const UnknownFname = "<unknown>"
+
 type Map struct {
 	*ebpf.Map
 }
@@ -49,15 +51,15 @@ func (m Map) Dump() ([]DumpEntry, error) {
 	var val []MapVal
 	var ret []DumpEntry
 
-	fileIDs, err := getFileIDs()
+	fileIDs, err := GetFileIDs()
 	if err != nil {
 		return nil, err
 	}
 	iter := m.Iterate()
 	for iter.Next(&key, &val) {
 		fname, ok := fileIDs[int(key.FileID)]
 		if !ok {
-			fname = "<unknown>"
+			fname = UnknownFname
 		}
 		count := 0
 		for _, v := range val {