Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update all go dependencies main #1372

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

cilium-renovate[bot]
Copy link
Contributor

@cilium-renovate cilium-renovate bot commented Aug 21, 2023

This PR contains the following updates:

Package Type Update Change
github.com/cilium/little-vm-helper require digest 3743163 -> 5fec602
github.com/sryoya/protorand require digest e5ae259 -> 5e0808b

Configuration

📅 Schedule: Branch creation - "on monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@cilium-renovate cilium-renovate bot requested a review from a team as a code owner August 21, 2023 09:11
@cilium-renovate cilium-renovate bot requested a review from willfindlay August 21, 2023 09:11
@cilium-renovate cilium-renovate bot added kind/enhancement This improves or streamlines existing functionality release-blocker This PR or issue is blocking the next release. labels Aug 21, 2023
@cilium-renovate cilium-renovate bot changed the title fix(deps): update golang.org/x/exp digest to d852ddb fix(deps): update all go dependencies main Aug 21, 2023
@cilium-renovate cilium-renovate bot force-pushed the renovate/all-go-deps-main branch 2 times, most recently from c6af9c6 to 5b0d1bd Compare August 25, 2023 09:10
@cilium-renovate cilium-renovate bot force-pushed the renovate/all-go-deps-main branch 5 times, most recently from f38c491 to 6aa4460 Compare September 6, 2023 09:07
@cilium-renovate cilium-renovate bot force-pushed the renovate/all-go-deps-main branch 2 times, most recently from 6a476c3 to ff9cf41 Compare September 11, 2023 18:08
@cilium-renovate cilium-renovate bot force-pushed the renovate/all-go-deps-main branch from ff9cf41 to 68052c0 Compare September 18, 2023 18:08
@cilium-renovate cilium-renovate bot force-pushed the renovate/all-go-deps-main branch 5 times, most recently from 63dbb21 to d328c15 Compare October 2, 2023 18:15
@cilium-renovate cilium-renovate bot force-pushed the renovate/all-go-deps-main branch from d328c15 to 152d712 Compare October 4, 2023 19:11
@lambdanis
Copy link
Contributor

lambdanis commented Oct 5, 2023

It looks like bumping the version of k8s.io/kube-openapi breaks everything, kubernetes/kube-openapi#404 is likely the problem or at least one of them.

I think k8s.io/kube-openapi should be bumped together with other k8s deps. Update for k8s.io/* are excluded in the Renovate config:

{
"enabled": false,
"matchPackagePatterns": [
// k8s dependencies will be updated manually along cilium updates
"k8s\\.io/*",
"sigs\\.k8s\\.io/*"
],
"matchUpdateTypes": [
"major",
"minor",
],
}
but only for minor and major updates.

@lambdanis
Copy link
Contributor

Ok, I've attempted to fix it in #1557.

@cilium-renovate cilium-renovate bot force-pushed the renovate/all-go-deps-main branch from 152d712 to 7f1291e Compare October 6, 2023 08:30
@mtardy
Copy link
Member

mtardy commented Oct 6, 2023

Ok, I've attempted to fix it in #1557.

your patch worked, is it now excluded but as I remember, the PR was failing even before that dependency needed an upgrade.

@lambdanis
Copy link
Contributor

It seems that this linter error

pkg/ftrace/ftrace.go:45:21: S (type string) does not satisfy ~[]E

is caused by the golang.org/x/exp update, some signatures changed in the slices package. But in Go 1.21 slices is a part of the Go stdlib, so we can just get rid of this dependency. I created #1560 for this.

Signed-off-by: cilium-renovate[bot] <134692979+cilium-renovate[bot]@users.noreply.github.com>
@cilium-renovate cilium-renovate bot force-pushed the renovate/all-go-deps-main branch from 7f1291e to 8bbaefd Compare October 6, 2023 18:10
@mtardy
Copy link
Member

mtardy commented Oct 6, 2023

It seems that this linter error


pkg/ftrace/ftrace.go:45:21: S (type string) does not satisfy ~[]E

is caused by the golang.org/x/exp update, some signatures changed in the slices package. But in Go 1.21 slices is a part of the Go stdlib, so we can just get rid of this dependency. I created #1560 for this.

Thanks so much for taking care of this! Indeed that fixes the issue :)

@mtardy mtardy added the release-note/dependency This PR updates one or multiple dependencies label Oct 6, 2023
@lambdanis lambdanis merged commit 78cee2b into main Oct 9, 2023
@lambdanis lambdanis deleted the renovate/all-go-deps-main branch October 9, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement This improves or streamlines existing functionality release-blocker This PR or issue is blocking the next release. release-note/dependency This PR updates one or multiple dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants