api: add a policy_name field to kprobe, tracepoint and uprobe events #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtardy
added
the
release-note/minor
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kkourt
approved these changes
Oct 11, 2023
All the plumbing was actually done, it was only missing the faucet. The policy name was stored in the kprobe, tracepoint or uprobe tables entries. It's only for uprobe that we also needed to copy the policy name from the internal API event to the unix event. Then for all three, the missing piece was the copy form the unix event to the gRPC API event. Signed-off-by: Mahe Tardy <[email protected]>
mtardy
force-pushed
the
pr/mtardy/add-tracing-policy-name
branch
from
7d280bd to
136d918
Compare
kkourt
added
release-note/major
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1477, I had a few minutes and I decided to implement this. I tested it manually!
All the plumbing was actually done, it was only missing the faucet. The policy name was stored in the kprobe, tracepoint or uprobe tables entries. It's only for uprobe that we also needed to copy the policy name from the internal API event to the unix event. Then for all three, the missing piece was the copy from the unix event to the gRPC API event.
I decided on
policy_nameinstead oftracing_policy_namebut we can discuss that...