Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRD handling refactor #1576

Merged
merged 4 commits into from
Oct 12, 2023
Merged

CRD handling refactor #1576

merged 4 commits into from
Oct 12, 2023

Conversation

kkourt
Copy link
Contributor

@kkourt kkourt commented Oct 11, 2023

This PR:

  • fixes an issue with the operator not respecting command line arguments
  • refactors CRD handling of pkg/k8s

@kkourt kkourt added the release-note/misc This PR makes changes that have no direct user impact. label Oct 11, 2023
@kkourt kkourt force-pushed the pr/kkourt/k8s-refactor branch 3 times, most recently from 8ac588a to 47979cd Compare October 11, 2023 08:54
@netlify
Copy link

netlify bot commented Oct 11, 2023 •
edited
Loading

✅ Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit c0b72a5
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/6527807e53165d00085c0674
😎 Deploy Preview https://deploy-preview-1576--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kkourt
Copy link
Contributor Author

kkourt commented Oct 12, 2023 •
edited
Loading

failure is in bpf-next:

❌ pkg.sensors.exec.TestEventExitThreads 3.651s (42.538s)

which is a known issue. Fixed in: #1581

Edit: rebased to include above PR.

@kkourt kkourt marked this pull request as ready for review October 12, 2023 05:10
@kkourt kkourt requested review from willfindlay and a team as code owners October 12, 2023 05:10
kkourt added 4 commits October 12, 2023 07:13
@kkourt
operator: fix viper bindings
e3f180f 
Signed-off-by: Kornilios Kourtis <[email protected]>
@kkourt
pkg/k8s: refactor CRD handling
c54bfc2 
This patch refactors CRD handling.

It introduces a new package (crdutils) that includes a CRD type, meant
to hold all the information for registering a CRD.

Registration code is moved into crdutils, and the caller just needs to
specify the CRD objects to register.

Signed-off-by: Kornilios Kourtis <[email protected]>
@kkourt
gh: add more info for generated-files test
940f4fe 
Signed-off-by: Kornilios Kourtis <[email protected]>
@kkourt
api/vendor/modules.txt: fix comment
c0b72a5 
For some reason, the CI generated version is different from my local
one. Let's use whatever CI expects.

Signed-off-by: Kornilios Kourtis <[email protected]>
@kkourt kkourt force-pushed the pr/kkourt/k8s-refactor branch from 5836cca to c0b72a5 Compare October 12, 2023 05:13
@jrfastab jrfastab merged commit e36e57e into main Oct 12, 2023
31 checks passed
@jrfastab jrfastab deleted the pr/kkourt/k8s-refactor branch October 12, 2023 19:59
@p-linnane p-linnane mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willfindlay willfindlay Awaiting requested review from willfindlay

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkourt @jrfastab