Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install-k8s.md #1753

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Update install-k8s.md #1753

merged 2 commits into from
Nov 24, 2023

Conversation

lizrice
Copy link
Member

@lizrice lizrice commented Nov 14, 2023

Fix typo in Kind instructions

Fix typo

Signed-off-by: Liz Rice <[email protected]>
@lizrice lizrice requested review from mtardy and a team as code owners November 14, 2023 12:53
Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 1cc4841
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/6555c1f2294c410008958f3a
😎 Deploy Preview https://deploy-preview-1753--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lizrice
Copy link
Member Author

lizrice commented Nov 14, 2023

Even with this (presumed) correction I'm getting this (using Kind on Mac):

helm install tetragon ${EXTRA_HELM_FLAGS} cilium/tetragon -n kube-system

Error: unknown flag: --set tetragon.hostProcPath

@mtardy
Copy link
Member

mtardy commented Nov 14, 2023

Even with this (presumed) correction I'm getting this (using Kind on Mac):

helm install tetragon ${EXTRA_HELM_FLAGS} cilium/tetragon -n kube-system

Error: unknown flag: --set tetragon.hostProcPath

Thanks for the typo fix, this is weird, the flag does exist and is used in some places.

Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is good but maybe it would be nice to get to the bottom of this before merging?

@mtardy mtardy added area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation. labels Nov 14, 2023
@kkourt
Copy link
Contributor

kkourt commented Nov 16, 2023

The fix is good but maybe it would be nice to get to the bottom of this before merging?

This flag was introduced in 1.0, so my guess is the kind chart that produced the error was before 1.0.
I've also realized, however, that the kind config would only work on Linux systems. So I pushed an additional patch to make this distinction. Let me know what you think.

@kkourt kkourt merged commit 6fb6188 into main Nov 24, 2023
9 checks passed
@kkourt kkourt deleted the lizrice-patch-1 branch November 24, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants