Move Helm chart into tetragon directory #1845
Conversation
lambdanis
added
kind/cleanup
lambdanis
requested review from
a team,
mtardy and
willfindlay
as code owners
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The links-checker CI workflow fails, because https://github.com/cilium/tetragon/tree/main/install/kubernetes/tetragon will be a thing only after this PR is merged. Maybe this doc should point to a tag instead of main branch and get updated on release. @mtardy wdyt? |
This kind of links (that will be created by the PR) will always fail surely. What I could do is to replace |
| @@ -47,7 +47,7 @@ The Tetragon Helm chart source is available under | |||
| and is distributed from the Cilium helm charts repository [helm.cilium.io](https://helm.cilium.io). | |||
|
|
|||
| To deploy Tetragon using this Helm chart you can run the following commands: | |||
| ```shell-session | |||
| ```shell | |||
There was a problem hiding this comment.
Thanks! well spotted, the new theme uses shell everywhere, really well spotted it just changed.
There was a problem hiding this comment.
heh, install/kubernetes/tetragon/test.sh was actually failing without this change :)
| /install/kubernetes/tetragon/README.md linguist-generated | ||
| /docs/content/en/docs/reference/helm-chart.md linguist-generated |
There was a problem hiding this comment.
wow that's amazing, TIL! I explicitly excluded myself has a code owner from those files but I guess this is even better?
| pushd install/kubernetes/tetragon | ||
| ./test.sh | ||
| popd | ||
| ./install/kubernetes/test.sh |
There was a problem hiding this comment.
Indeed this is no longer needed, you saw this 357206b, you have 👀 everywhere.
Moving all chart files and helper scripts one level deeper: from install/kubernetes to install/kubernetes/tetragon. The goal is to make it easier to develop tooling around templating the Helm chart in the future. The only code change here is in test.sh: the path of the Helm chart docs is prefixed by one more ../ Signed-off-by: Anna Kapuscinska <[email protected]>
Replacing all references to install/kubernetes with install/kubernetes/tetragon: * Makefile * Renovate configuration * release issue template * Github Actions * script updating Helm chart for release * script for local dev installation * documentation * script generating Helm docs Signed-off-by: Anna Kapuscinska <[email protected]>
There is no need to package these scripts together with the chart, so let's move the out. I also made necessary adjustments to the scripts (paths). Signed-off-by: Anna Kapuscinska <[email protected]>
This will mark generated files in pull requests for easier code reviews. Signed-off-by: Anna Kapuscinska <[email protected]>
lambdanis
force-pushed
the
pr/lambdanis/helmrefactor
branch
from
c09462e to
dcb5e80
Compare
Signed-off-by: Anna Kapuscinska <[email protected]>
For some reason the Tetragon Helm chart contained the Kubeval license. Replacing it with the correct Apache 2.0 license. Signed-off-by: Anna Kapuscinska <[email protected]>
lambdanis
force-pushed
the
pr/lambdanis/helmrefactor
branch
from
dcb5e80 to
96d9807
Compare
|
I'm merging it, the links-checker CI job should pass on main (see #1858). cilium/charts#88 needs to follow. |
See commits for details (and let me know if I should squash some of them). It's done mainly to make tooling (scripts) separate from the Helm chart, and also for consistency with other projects.