Actions: add rateLimitScope #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevsecurity
added
the
release-note/minor
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kevsecurity
force-pushed
the
pr/kevsecurity/apply-rate-limit-to-all-threads
branch
2 times, most recently
from
deaba76 to
78262f0
Compare
tixxdz
approved these changes
Jan 11, 2024
| @@ -1926,9 +1930,20 @@ rate_limit(__u64 ratelimit_interval, struct msg_generic_kprobe *e) | |||
| ro_heap = map_lookup_elem(&ratelimit_ro_heap, &zero); | |||
|
|
|||
| key->func_id = e->func_id; | |||
| key->retprobe_id = e->retprobe_id; | |||
There was a problem hiding this comment.
Yeah was overkill.
| @@ -1926,9 +1930,20 @@ rate_limit(__u64 ratelimit_interval, struct msg_generic_kprobe *e) | |||
| ro_heap = map_lookup_elem(&ratelimit_ro_heap, &zero); | |||
|
|
|||
There was a problem hiding this comment.
would it make sense to memset zero those returned heap entries? (didn't check all the logic)
There was a problem hiding this comment.
I overwrite the heap with a read only heap that is all zero, using a probe_read. It should cost about the same as a memset but doesn't cost me the instruction / complexity count.
Yeah I forgot the version! I'll do that now. |
Post actions can have a rateLimit argument that specifies how often identical events from the same hook and thread are generated. There is a use case to rate limit per process or generally. This commit introduces the rateLimitScope argument, to be used with rateLimit, to specify whether the rate limiting should be limited to the same thread, the same process, or globally, using values "thread" (default), "process", or "global". Signed-off-by: Kevin Sheldrake <[email protected]>
kevsecurity
force-pushed
the
pr/kevsecurity/apply-rate-limit-to-all-threads
branch
from
78262f0 to
abbc757
Compare
kevsecurity
deleted the
pr/kevsecurity/apply-rate-limit-to-all-threads
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post actions can have a rateLimit argument that specifies how often identical events from the same hook and thread are generated. There is a use case to rate limit per process or generally.
This commit introduces the rateLimitScope argument, to be used with rateLimit, to specify whether the rate limiting should be limited to the same thread, the same process, or globally, using values "thread" (default), "process", or "global".