-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: tetragon troubleshoot improve #2115
Conversation
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for taking the time to do that, I have some remarks on the form, I hope it's not too much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, to me it looks good! Could you squash your commits into one with only your first commit message? Thanks :)
Hey, I saw you added a merge commit. Please use |
Thanks @mtardy quite confused about how to squash commit after the merge commit, it shows various commits to pick(that's probably of others who got in the merge commit)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right I did the fix for you, here are a few things to consider please on the content this time, sorry I didn't do everything at once. Please try to amend the existing commit with your changes or add commits and then squash them.
@mtardy I did the required changes and amended the commit (apologies quite confused, how did I get others commits here). |
Thanks for taking the time to do the changes! Sorry this time you'll need to cleanup your PR. Instead of opening a new PR like last time or me tidying up stuff, I think you should take some time to get more familiar with git and |
9bb78ef
to
39c8ea9
Compare
@mtardy I squash the commits into a single one, but how to remove others' file changes. Apologies for the inconvenience. |
Co-authored-by: Mahe Tardy <[email protected]> Signed-off-by: janvi01 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge that, I forced pushed again removing all the changes from other commits you merged into your initial commit.
While we really appreciate you taking the time to write documentation, please take a bit more time next time testing the commands you put in the documentation. Almost all of them were not working.
- the
kubectl get pods -l app.kubernetes.io/name=tetragon
label was wrong, with a space instead of the/
- the
kubectl exec
was missing the-c tetragon
option - the
kubectl cp
was missing the-c tetragon
and the archive name was wrong. - the
docker cp
had a wrong archive name.
Improved doc around tetra bugtool, demo how to run it for all different installation k8s, container or systemd host installation.
Fixes #1974 second tick box.