makefile: containerize CRD generation and rename codegen and generate targets #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willfindlay
added
the
release-note/misc
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lambdanis
approved these changes
Feb 22, 2024
mtardy
reviewed
Feb 22, 2024
We encountered some version-specific differences related to golang tooling which impact the resulting CRD generation from make generate. To solve this problem, let's containerize the CRD generation workflow so that we can get consistent output through consistent tooling. while we're at it, rename the generate target to crds to disambiguate it from protobuf code generation. We keep the old generate target around as an alias for backward compatibility. Signed-off-by: William Findlay <[email protected]>
Now that we have renamed the generate target to crds, it makes sense to also rename to codegen target to make it more clear that it specifically refers to protobuf codegen. Just as with make generate, we keep the old codegen target around to use as an alias for backward compatbility. We also remove the original protogen dockerfile as it is no longer needed. Instead, we can simply use the base cilium-builder image. Signed-off-by: William Findlay <[email protected]>
willfindlay
force-pushed
the
pr/willfindlay/containerized-generate
branch
from
731c0f6 to
6df735d
Compare
mtardy
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Containerize the CRD generation workflow to resolve a version consistency issue we encountered. Rename the generate and codegen targets to disambiguate them.