fix policyfilter metrics #2282
Merged
fix policyfilter metrics #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkourt
added
the
release-note/misc
This reverts commit 425f91e. Signed-off-by: Kornilios Kourtis <[email protected]>
Commit 425f91e ("policyfiltermetrics: Remove error label") was reverted in the previous patch included some misc fixes for log messages. Add them here. Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt
force-pushed
the
pr/kkourt/policyfilter-errors
branch
2 times, most recently
from
f896496 to
4366929
Compare
kkourt
force-pushed
the
pr/kkourt/policyfilter-errors
branch
2 times, most recently
from
3f78912 to
05bec85
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Apr 3, 2024
lambdanis
reviewed
Apr 3, 2024
This patch implements ErrorLabel() for generating error labels for metrics. This fixes an issue with the previous implementation where the cardinality of the error_type label was potentially unbounded. Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt
force-pushed
the
pr/kkourt/policyfilter-errors
branch
from
05bec85 to
c0fe8ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
323ec1e removed the error label from metrics. This PR reverts this patch and fixes the issue of potentially high cardinality in metrics.