bpf: use CORE for execve hook #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users reported an issue on RHEL 9 with binary names being wrong.
Looking at the sched/sched_process_exec tracepoint we hook into:
$ cat /sys/kernel/debug/tracing/events/sched/sched_process_exec/format
name: sched_process_exec
ID: 310
format:
field:unsigned short common_type; offset:0; size:2; signed:0;
field:unsigned char common_flags; offset:2; size:1; signed:0;
field:unsigned char common_preempt_count; offset:3; size:1; signed:0;
field:int common_pid; offset:4; size:4; signed:1;
field:unsigned char common_preempt_lazy_count; offset:8; size:1; signed:0;
field:__data_loc char[] filename; offset:12; size:4; signed:1;
field:pid_t pid; offset:16; size:4; signed:1;
field:pid_t old_pid; offset:20; size:4; signed:1;
There is an additional argument: common_preempt_lazy_count, which means
that the struct we use (sched_execve_args) is no longer valid.
This patch removes the above struct, and instead, uses CORE and the
trace_event_raw_sched_process_exec struct.
Reproduced and patch tested locally on a Rocky Linux 5.3 with a
5.14.0-362.24.1.el9_3.0.1.x86_64 kernel.
Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt
added
the
release-note/bug
|
Marked it for backporting |
|
oh wow, nice catch indeed that could be the issue, and finally fixing this long-standing issue. |
|
Is it in 1.1 already? |
Not yet. Will do the backport soon. |
|
backport: #2468 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users reported an issue on RHEL 9 with binary names being wrong.
Looking at the sched/sched_process_exec tracepoint we hook into:
There is an additional argument: common_preempt_lazy_count, which means that the struct we use (sched_execve_args) is no longer valid.
This patch removes the above struct, and instead, uses CORE and the trace_event_raw_sched_process_exec struct.
Reproduced and patch tested locally on a Rocky Linux 5.3 with a 5.14.0-362.24.1.el9_3.0.1.x86_64 kernel.
Fixes: #1707