btf: take first entry on multiple btf validation #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tixxdz
added
the
release-note/minor
tixxdz
force-pushed
the
pr/tixxdz/btf-validation-take-first-id-on-multiple-matches
branch
from
9d9d421 to
1324bbc
Compare
olsajiri
reviewed
May 31, 2024
tixxdz
force-pushed
the
pr/tixxdz/btf-validation-take-first-id-on-multiple-matches
branch
from
1324bbc to
de6b5b9
Compare
olsajiri
approved these changes
Jun 1, 2024
tixxdz
force-pushed
the
pr/tixxdz/btf-validation-take-first-id-on-multiple-matches
branch
from
de6b5b9 to
3ae527f
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tixxdz
force-pushed
the
pr/tixxdz/btf-validation-take-first-id-on-multiple-matches
branch
from
3ae527f to
712cafe
Compare
|
Thanks Jiri, I added an if guard in case and tried to silence some go lint warning maybe. If it is green I merge. |
TypeByName() can fail with ErrMultipleMatches if we have multiple candidates. If so, let's try again and take first match as it is. This can help solve our immediate issue of having multiple definitions per system calls, however the long-term fix would be to iterate over all candidate, match their proto and arguments definitions, then attach to the corresponding ones. Example output: time="2024-05-31T15:53:17+01:00" level=info msg="BTF includes '2' matched candidates on call \"__x64_sys_init_module\", using first one" metadata=/home/tixxdz/btf Signed-off-by: Djalal Harouni <[email protected]>
tixxdz
force-pushed
the
pr/tixxdz/btf-validation-take-first-id-on-multiple-matches
branch
from
712cafe to
6fdddd3
Compare
tixxdz
deleted the
pr/tixxdz/btf-validation-take-first-id-on-multiple-matches
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.