[backport v1.1] pkg/sensors: reduce ratelimit map memory footprint #2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit ed824b3 ] Since the rate limit feature is only available for LARGE_BPF_PROG, let's remove the unnecessary map and the struct from the small BPF progs. Signed-off-by: Mahe Tardy <[email protected]>
[ upstream commit 38ab012 ] Signed-off-by: Mahe Tardy <[email protected]>
[ upstream commit 850410b ] For every ratelimit map loaded, we add ~10MB of kernel memory, and each kprobe added was adding a ratelimit map. We now only load that map if the user used the rateLimit field in a matchActions to reduce the memory footprint of this feature when unused. Signed-off-by: Mahe Tardy <[email protected]>
[ upstream commit 1eea47b ] Add a NoRateLimit test and a RateLimitTest. Signed-off-by: Kevin Sheldrake <[email protected]>
mtardy
added
the
kind/backport
mtardy
added
the
release-note/bug
[ upstream commit a1a2499 ] Commit 38ab012 pinned the ratelimit_map to the fs but used sensorPath instead pinPath since this is a per kprobe map and not a per sensor map. Signed-off-by: Mahe Tardy <[email protected]>
kkourt
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2551 and #2583