pkg/sensors: fix binprm matchArgs test #2624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was broken in two ways: - First it was using the "In" operator with MatchArgs, which does not exist. "Equal" should be used. It can be confusing because MatchBinaries uses "In". It bypasses validation since it provided the Go object without using the YAML unmarshalling. - Secondly, it was only checking that the event existed without checking that the filtering actually happened. We can check the "lack" of event in addition to the presence of it thanks to the way this test is written, using the perfring.RunTestEvents. This test should have detected the issue fixed by the following patch. Signed-off-by: Mahe Tardy <[email protected]>
Signed-off-by: Andrei Fedotov <[email protected]>
mtardy
added
the
release-note/bug
mtardy
requested review from
tixxdz,
dwindsor and
kevsecurity
and removed request for
tixxdz
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kevsecurity
approved these changes
Jul 2, 2024
kkourt
approved these changes
Jul 3, 2024
|
Seems to fail in 4.19:
Maybe we need to skip the test if Line 217 in e44f7df |
|
I guess we don't need this one now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2623 work. Given this comment #2623 (comment).
cc @anfedotoff @dwindsor.
Running the test with the first commit only should fail as expected:
go test -exec sudo ./pkg/sensors/tracing --run TestLinuxBinprmExtractPathWith @anfedotoff patch, the test should now be green.