helm: Remove deprecated tetragonOperator.skipCRDCreation value #2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch makes the following changes: 1. Remove deprecated "tetragon.skipCRDCreation" from the operator config map and set "false" as the static value in "skip-crd-creation" 2. Rename "tetragon.skipCRDCreation" to "tetragonOperator.skipCRDCreation" in the upgrade notes for Tetragon 1.2.0 Signed-off-by: Oleh Neichev <[email protected]>
BonySmoke
changed the title
mtardy
added
the
release-note/misc
lambdanis
added
area/helm
lambdanis
added
backport-pending/1.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR #2498, the
tetragon.skipCRDCreationkey was removed from thevalues.yamlfile; however, there is still a reference to it in the operator config map.From what I understand, the operator expects a boolean value, and in case the installation method is
operator, it should be set tofalse.The patch makes the following changes:
tetragon.skipCRDCreationfrom the operator config map and setfalseas the static value inskip-crd-creation.tetragon.skipCRDCreationtotetragonOperator.skipCRDCreationin the upgrade notes for Tetragon1.2.0.Changelog