-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] fix probe_read_str return type #3236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix
please add the description from the PR to the changelog
@@ -130,7 +130,7 @@ FUNC_INLINE __u32 | |||
read_path(void *ctx, struct msg_execve_event *event, void *filename) | |||
{ | |||
struct msg_process *p = &event->process; | |||
__u32 size = 0; | |||
int size = 0; | |||
__u32 flags = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch, please use __s32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! I touched your changelog, could you squash your two commits into one so that we can merge this :)
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey, you have 4 commits now, you can do this to squash those commits into one: git rebase -i <first commit of the branch>^ Then put git push origin HEAD --force-with-lease |
Signed-off-by: arthur-zhang <[email protected]>
ok,
thanks, done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! :)
Fixes potential bug
Description
Since size is an unsigned type (__u32), it will never be less than 0. Therefore, the following code logic will never be executed:
Changelog