Fixes for Live mode, Linux and Firebird 3 compatibility #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommand header This is needed for Firebird 3 support.
When receiving a message in live mode append a newline to it before processing it and allow an additional trailing space on the statement id line and table header lines. The above fixes failing statement finish processing when in live mode.
…ment prepare Firebird 3 uses this when working with generators (and maybe other cases).
Firebird 3 (2+?) shows the initial transaction id in the header for commit retaining transactions.
In Firebird 3 it is reported with COMMIT RETAINING transactions.
|
Hi. Thanks for the contribution. It would be better to create separate PRs. It's easier to manage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I found some bugs while trying to run the tool against Firebird 3 on Linux in Live mode - with the fixes in this pull request it seems to work with a production server with the same environment.
I wasn't sure if I should create separate pull requests so I created only one to keep the conversation in one place.