worksheets Order needs to be annotated as omitempty #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-
added a commit
to circonus-labs/terraform-provider-circonus
that referenced
this pull request
Sep 29, 2018
This is a required workaround until circonus-labs/circonus-gometrics/pull/79 is merged.
sean-
added a commit
to circonus-labs/terraform-provider-circonus
that referenced
this pull request
Sep 29, 2018
This is a required workaround until circonus-labs/circonus-gometrics/pull/79 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Orderattribute is not a required attribute forWorksheetSmartQuerywhen posting to the API endpoint. It should be marked asomitempty. If this attribute is going to be made required in the near future, a helper methodNewWorksheetSmartQuery()should be created that populates theOrderattribute with an empty string list. In addition to https://github.com/terraform-providers/terraform-provider-circonus/pull/22, this is required to fix thecirconus_worksheetresource interraform-provider-circonus.