Relay 9

[RDIL]

Signed-off-by: Reece Dunham [email protected]

New in this PR 🔥

Feature 🖥

• Relay v9
• Synced graphql schema
• TypeScript 3.8

Dependencies ⛽️

• Update @material-ui/core
• Update Jest types
• Update NodeJS types
• Update React types
• Update the stripe API package

Bug Fixes 🐞

• Docker: source maps are generated by default

---

[fkorotkov]

I'm hesitant about switching to react-loadable. Yeutech Lab
just copied it without even mentioning it's a fork and keeping a list of alleged users from the original library.

This project was originally hosted at https://github.com/jamiebuilds/react-loadable

^^ sounds like they now officially maintain the project but I didn't find any confirmation. Based on this comment it seems they just decided to copy the project without even properly forking and merge in the change. There were no changes since the fork was create and don't have any certainty "this community fork" will be better maintained.

[RDIL]

Actually, they do credit the original project, see https://github.com/yeutech-lab/react-loadable#why-did-we-fork

[RDIL]

Its a community fork, they fixed the bugs and left it, I don't see why not updating the list of users is so bad. They made the changes needed, and left it.

[fkorotkov]

Here are my concerns about using this "fork":

• There is 86 weekly downloads of the package from NPM
• It was copied by an individual with only one change that he wanted to merge.
• IMO it was weirdly forked. Copied with these two lines about the original project while keeping the list of users.
• All of the above makes me hard to call this project coming from react-loadable community yet.
• React 17 is not yet release and this upgrade is not at all related to the matter of this issue: update Relay.

[RDIL]

Fixed

[fkorotkov]

Regarding the react-loadable. It seems https://github.com/gregberge/loadable-components worth investigation.

[velusgautam]

https://www.npmjs.com/package/react-loadable-hooks implementation with React 17

[fkorotkov]

@velusgautam ended up switching to React's lazy right after is #159