Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Functional and Smoke Tests to use the ScubaResults.json rather than the ProviderSettingsExport.json #1317

Open
buidav opened this issue Sep 16, 2024 · 1 comment
Labels
enhancement This issue or pull request will add new or improve existing functionality
Milestone

Comments

@buidav
Copy link
Collaborator

buidav commented Sep 16, 2024

💡 Summary

This is the follow up to PR #1316.
The current functional tests are heavily dependent on the ProviderSettingsExport.json with change to making
ScubaResults.json the default we need to update the functional tests to match the new behavior.

Smoke tests may need to be updated as well.

Motivation and context

To make sure our tests cover the final ScubaGear output: ScubaResults.json rather than the old ProviderSettingsExport.json.

Implementation notes

  • Update the code in the Testing/Functional/Products to start using ScubaResults.json.
  • Update the code in the Testing/Functional/SmokeTest to start using ScubaResults.json If necessary.
  • Remove the -KeepIndividualJSON flags from Invoke-SCuBA and Invoke-SCuBACached in the workflow code.

Acceptance criteria

  • Functional and Smoke tests work around the new ScubaResults output file.
@buidav buidav added the enhancement This issue or pull request will add new or improve existing functionality label Sep 16, 2024
@schrolla
Copy link
Collaborator

Definitely requires some significant updates to our functional tests apparatus. Particularly for those working off cached data as methods like UpdateProviderExport and PublishProviderExport currently target the provider file for making changes.

@schrolla schrolla added this to the Kraken milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants