Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
The
azure/login
GitHub action allows our publishing workflows to access our code signing certificate from an Azure Key Vault. However, GitHub has deprecated azure/login@v1 due to the end of life of Node.js v16 used by this action. The newer @v2 uses the supported Node.js v20 software and resolves the login issue in our workflows.💭 Motivation and context
The publish workflows that use the azure/login action are failing as the previous version is now deprecated and causing it the login to fail on execution. Upgrading the action to the latest (v2) resolves the issue.
Closes #1049
🧪 Testing
Review the most recent failed
Publish and sign Draft Release
andPublish public package
action results to see the issue and note the deprecation warning.See successful results of
Build and Sign Release
workflow on this branch here: https://github.com/cisagov/ScubaGear/actions/runs/9407521339/job/25913440630✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
✅ Post-merge checklist