Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump azure/login action to v2 #1152

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

schrolla
Copy link
Collaborator

@schrolla schrolla commented Jun 6, 2024

🗣 Description

The azure/login GitHub action allows our publishing workflows to access our code signing certificate from an Azure Key Vault. However, GitHub has deprecated azure/login@v1 due to the end of life of Node.js v16 used by this action. The newer @v2 uses the supported Node.js v20 software and resolves the login issue in our workflows.

💭 Motivation and context

The publish workflows that use the azure/login action are failing as the previous version is now deprecated and causing it the login to fail on execution. Upgrading the action to the latest (v2) resolves the issue.
Closes #1049

🧪 Testing

Review the most recent failed Publish and sign Draft Release and Publish public package action results to see the issue and note the deprecation warning.

See successful results of Build and Sign Release workflow on this branch here: https://github.com/cisagov/ScubaGear/actions/runs/9407521339/job/25913440630

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@schrolla schrolla added bug This issue or pull request addresses broken functionality upstream update This issue or pull request pulls in upstream updates labels Jun 6, 2024
@schrolla schrolla added this to the Halibut milestone Jun 6, 2024
@schrolla schrolla self-assigned this Jun 6, 2024
@schrolla schrolla linked an issue Jun 6, 2024 that may be closed by this pull request
1 task
@schrolla schrolla requested review from adhilto and buidav June 6, 2024 20:35
Copy link
Collaborator

@buidav buidav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just a quick version bump.

@schrolla schrolla marked this pull request as ready for review June 6, 2024 20:43
@schrolla
Copy link
Collaborator Author

schrolla commented Jun 6, 2024

@nanda-katikaneni Ready for merge.

@nanda-katikaneni nanda-katikaneni merged commit faedc6b into main Jun 6, 2024
18 checks passed
@nanda-katikaneni nanda-katikaneni deleted the 1049-update-jobs-with-azurelogin-to-v2 branch June 6, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality upstream update This issue or pull request pulls in upstream updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update jobs with azure/login to v2
4 participants