Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin PowerApps module to last working version #1346

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

schrolla
Copy link
Collaborator

@schrolla schrolla commented Sep 30, 2024

🗣 Description

This request addresses the bugged version of the Microsoft PowerApps module by pinning ScubaGear required version to the last working version.

💭 Motivation and context

ScubaGear requires a working PowerApps module in order to adequately assess the PowerPlatform service.

Closes #1345

🧪 Testing

  1. First, remove any existing version of Microsoft.PowerApps.Administration.PowerShell from your test machine to ensure you do not have the bugged version (2.0.197) via Uninstall-Module -Name Microsoft.PowerApps.Administration.PowerShell
  2. Run Initialize-ScubaGear to get the latest working version of the module (2.0.194)
  3. Run Invoke-SCuBA -p powerplatform to verify ScubaGear works as intended without errors as shown in Microsoft.PowerApps.Administration.PowerShell module v2.0.197 cannot be imported #1345

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@schrolla schrolla added bug This issue or pull request addresses broken functionality upstream update This issue or pull request pulls in upstream updates labels Sep 30, 2024
@schrolla schrolla added this to the Jellyfish milestone Sep 30, 2024
@schrolla schrolla self-assigned this Sep 30, 2024
@schrolla schrolla marked this pull request as ready for review September 30, 2024 21:46
@schrolla schrolla requested review from nanda-katikaneni, buidav and ahuynhMITRE and removed request for nanda-katikaneni September 30, 2024 21:46
Copy link
Collaborator

@buidav buidav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installed a fresh copy of the dependencies and see the new pinned version.
Ran Invoke-SCuBA with powerplatform successfully.
Looks good.
 versionPinning

Copy link
Collaborator

@ahuynhMITRE ahuynhMITRE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no additional comments, thanks for getting this pin in quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality upstream update This issue or pull request pulls in upstream updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Microsoft.PowerApps.Administration.PowerShell module v2.0.197 cannot be imported
3 participants