Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OPA version from v0.68.0 to v0.69.0 and Set new accepted minimum to v0.69.0 #1348

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 1, 2024

🗣 Description

  • This pull request was created by a GitHub Action to bump ScubaGear's Open Policy Agent (OPA) executable version dependency.
  • Updated to also set then new minimum version to v0.69.0 for the UTF8 strip BOM if found fix.
  • Updated the OPA workflow to handle update case when only a single version is found.

💭 Motivation and context

🧪 Testing

  • Currently a human should still check if bumping the OPA version affects ScubaGear.
  • After importing ScubaGear Import-Module .\PowerShell\ScubaGear run Install-OPAforSCuBA to download the latest version.`
  • Ran Invoke-SCuBA against a few of the tenants no issues.
  • Ran OPA unit tests no issues.
  • See this forked PR for how the workflow updates were tested.

📷 Screenshots

Passing unit tests.
unitTests

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@github-actions github-actions bot added the version bump This issue or pull request increments the version number label Oct 1, 2024
@buidav buidav self-assigned this Oct 1, 2024
@buidav buidav changed the title Bump OPA version from v0.68.0 to v0.69.0 Bump OPA version from v0.68.0 to v0.69.0 and Set new minimum to v0.69.0 Oct 1, 2024
@buidav buidav changed the title Bump OPA version from v0.68.0 to v0.69.0 and Set new minimum to v0.69.0 Bump OPA version from v0.68.0 to v0.69.0 and Set new accepted minimum to v0.69.0 Oct 1, 2024
@buidav buidav added this to the Jellyfish milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version bump This issue or pull request increments the version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants