Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker-compose-check Hook #111

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Conversation

Matthew-Grayson
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson commented Mar 19, 2024

🗣 Description

Add .env setup step to build.yml: addresses error by docker-compose-check hook.

💭 Motivation and context

The docker-compose-check hook relies on variables stored in a .env file. This file wasn't available in the GitHub Actions test environment, so I added a step to create it in the lint job.
Closes issue #108

🧪 Testing

All unit tests pass.
docker-compose-check hook passes.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@Matthew-Grayson Matthew-Grayson linked an issue Mar 19, 2024 that may be closed by this pull request
@Matthew-Grayson Matthew-Grayson marked this pull request as ready for review March 19, 2024 21:12
@Matthew-Grayson Matthew-Grayson self-assigned this Mar 19, 2024
@Matthew-Grayson Matthew-Grayson changed the title Add .env setup step to build.yml: addresses error by docker-compose-c… Fix docker-compose-check Hook Mar 20, 2024
@cduhn17 cduhn17 self-requested a review March 20, 2024 14:16
Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dav3r
Copy link
Member

dav3r commented Mar 20, 2024

I'm confused when you say:

Merging this and PR #48 fixes the only remaining failing pre-commit hooks.

First of all, #48 is an issue, not a PR. Did you mean PR #49, which resolved issue #48?

Second, this PR still shows those two JSON-related pre-commit hooks failing. If those JSON hooks were passing thanks to the changes in #49, why are those changes not included in this PR? If they were, then the build / lint tests in this PR should pass.

.github/workflows/build.yml Outdated Show resolved Hide resolved
@Matthew-Grayson
Copy link
Contributor Author

I'm confused when you say:

Merging this and PR #48 fixes the only remaining failing pre-commit hooks.

First of all, #48 is an issue, not a PR. Did you mean PR #49, which resolved issue #48?

Second, this PR still shows those two JSON-related pre-commit hooks failing. If those JSON hooks were passing thanks to the changes in #49, why are those changes not included in this PR? If they were, then the build / lint tests in this PR should pass.

I've since merged develop into this branch and updated the PR language to reflect that all pre-commit hooks pass.

Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@schmelz21 schmelz21 merged commit 34948bf into develop Mar 20, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix docker-compose-check
4 participants