-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial functionality #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think this account should also have the "disable inactive IAM users" jazz that I recently added to the COOL.
- Don't forget that when you rename you will have to migrate the state (defined in
backend.tf
) over to the new key name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. (I actually read it all.)
Strong work! 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even stronger! 🦾
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid groundwork here 💪💪💪 Just a few questions for your consideration.
This is a recent style pattern we have adopted. Co-authored-by: Jeremy Frasier <[email protected]>
… to the CyHy ProvisionAccount role
7e1ef64
to
10c9d32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to remove the unused variables from the README.md as well.
2b8140d
to
9c2d149
Compare
Co-authored-by: mcdonnnj <[email protected]>
This makes our bucket names unique and allows us to remove some local variables that are no longer needed. Co-authored-by: Nicholas McDonnell <[email protected]> Co-authored-by: Jeremy Frasier <[email protected]>
Co-authored-by: Nicholas McDonnell <[email protected]>
9c2d149
to
6ce0814
Compare
🗣 Description
This PR contains the first version of Terraform code to perform the initial configuration of a newly-created COOL Cyber Hygiene (CyHy) AWS account.
💭 Motivation and context
This is a necessary first step towards having a CyHy account that is a full-fledged member of the COOL.
NOTE: Per team consensus, I will rename this repo from
cool-accounts-cyhy
tocool-accounts-cyhy-tf-root
after this PR is merged.🧪 Testing
I applied this Terraform in a development environment and verified that it worked as intended.
✅ Pre-approval checklist
to reflect the changes in this PR.
✅ Post-merge checklist
cool-accounts-cyhy
tocool-accounts-cyhy-tf-root