-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn on Virtual Deliverability Manager #108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 5.20 of the Terraform AWS provider is the first version to offer the aws_sesv2_account_vdm_attributes resource, which we require in this root module.
…role-tf-module This is being done for testing purposes and can be reverted once cisagov/terraform-state-read-role-tf-module#37 is merged.
VDM will show us some useful information about emails that bounced, such as the diagnostic code indicating the reason for the bounce. We don't care about the engagement metrics, since we don't care to track if users click the attachments we send.
jsf9k
added
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
hacktoberfest-accepted
Pull request that should count toward Hacktoberfest participation
terraform
Pull requests that update Terraform code
labels
Oct 1, 2024
…ppression list This will allow suppression list managers to get a suppressed destination (which will include a message ID) and then get the insights for that particular message. This will allow the suppression list managers to view, e.g., the diagnostic code associated with the bounce.
This is something we should consider doing in the future, although I'm not sure it could be done non-destructively.
dv4harr10
approved these changes
Oct 1, 2024
dav3r
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This is issue #109.
…module We can do this now that cisagov/terraform-state-read-role-tf-module#37 has been merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
hacktoberfest-accepted
Pull request that should count toward Hacktoberfest participation
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
terraform
Pull requests that update Terraform code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request turns on the Virtual Deliverability Manager advisor in our SES account.
💭 Motivation and context
VDM will show us some useful information about emails that bounced, such as the diagnostic code indicating the reason for the bounce.
🧪 Testing
I successfully applied these changes to our COOL DNS account.
✅ Pre-approval checklist
✅ Pre-merge checklist