Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on Virtual Deliverability Manager #108

Merged
merged 8 commits into from
Oct 2, 2024
Merged

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Oct 1, 2024

🗣 Description

This pull request turns on the Virtual Deliverability Manager advisor in our SES account.

💭 Motivation and context

VDM will show us some useful information about emails that bounced, such as the diagnostic code indicating the reason for the bounce.

🧪 Testing

I successfully applied these changes to our COOL DNS account.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

Version 5.20 of the Terraform AWS provider is the first version
to offer the aws_sesv2_account_vdm_attributes resource, which we
require in this root module.
…role-tf-module

This is being done for testing purposes and can be reverted once
cisagov/terraform-state-read-role-tf-module#37 is merged.
VDM will show us some useful information about emails that bounced,
such as the diagnostic code indicating the reason for the bounce.

We don't care about the engagement metrics, since we don't care to
track if users click the attachments we send.
@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation terraform Pull requests that update Terraform code labels Oct 1, 2024
@jsf9k jsf9k self-assigned this Oct 1, 2024
…ppression list

This will allow suppression list managers to get a suppressed
destination (which will include a message ID) and then get the
insights for that particular message.  This will allow the suppression
list managers to view, e.g., the diagnostic code associated with the
bounce.
@jsf9k jsf9k marked this pull request as ready for review October 1, 2024 20:21
@jsf9k jsf9k requested a review from a team October 1, 2024 20:21
This is something we should consider doing in the future, although I'm
not sure it could be done non-destructively.
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

route53_static.tf Outdated Show resolved Hide resolved
@jsf9k jsf9k enabled auto-merge October 2, 2024 14:55
@jsf9k jsf9k merged commit 72dc2c9 into develop Oct 2, 2024
4 checks passed
@jsf9k jsf9k deleted the feature/turn-on-vdm branch October 2, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use terraform Pull requests that update Terraform code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants