Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TXT and CAA records for Crossfeed integration domain #111

Merged
merged 16 commits into from
Nov 13, 2024

Conversation

cduhn17
Copy link
Contributor

@cduhn17 cduhn17 commented Nov 12, 2024

Update domain name for integration

🗣 Description

We need to add the integration domain name and issue letsencrypt ssl certificates. There is a need for both a TXT record and CAA record

💭 Motivation and context

There are no existing ACME certs

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

@cduhn17 cduhn17 marked this pull request as ready for review November 12, 2024 17:36
@cduhn17
Copy link
Contributor Author

cduhn17 commented Nov 12, 2024

@dav3r ,
When you get a chance to take a look. I have certbot awaiting this change. Thanks

route53_crossfeed_app.tf Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@dav3r
Copy link
Member

dav3r commented Nov 12, 2024

@dav3r , When you get a chance to take a look. I have certbot awaiting this change. Thanks

@cduhn17 Once you address my suggestion, I can apply this change for you so that you can verify it.

@cduhn17
Copy link
Contributor Author

cduhn17 commented Nov 12, 2024

I applied your suggestions

@dav3r
Copy link
Member

dav3r commented Nov 12, 2024

I applied this change and created the new TXT record. Please confirm if all is well and I will approve this PR.

@dav3r dav3r self-assigned this Nov 12, 2024
@dav3r dav3r added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Nov 12, 2024
@cduhn17
Copy link
Contributor Author

cduhn17 commented Nov 12, 2024

It failed. I had to add a CAA record and modify the cerbot value.

README.md Outdated Show resolved Hide resolved
Co-authored-by: dav3r <[email protected]>
@dav3r
Copy link
Member

dav3r commented Nov 12, 2024

I just reapplied the TXT and CAA records - please let us know the result.

README.md Outdated Show resolved Hide resolved
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dav3r
Copy link
Member

dav3r commented Nov 13, 2024

@cduhn17 Can you please update the title and description to reflect the current state of this PR? Is everything looking good from your end or are there further changes needed?

@cduhn17
Copy link
Contributor Author

cduhn17 commented Nov 13, 2024

@dav3r ,

The certificates were created successfully. Thanks for your assistance and I will update the description to include the CAA record addition

@dav3r dav3r changed the title Update route53_crossfeed_app.tf to add TXT record for domain addition Add TXT and CAA records for Crossfeed integration domain Nov 13, 2024
@dav3r dav3r merged commit 8c5bdf9 into cisagov:develop Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants