-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TXT and CAA records for Crossfeed integration domain #111
Conversation
@dav3r , |
@cduhn17 Once you address my suggestion, I can apply this change for you so that you can verify it. |
Co-authored-by: dav3r <[email protected]>
Co-authored-by: dav3r <[email protected]>
I applied your suggestions |
I applied this change and created the new TXT record. Please confirm if all is well and I will approve this PR. |
It failed. I had to add a CAA record and modify the cerbot value. |
Co-authored-by: dav3r <[email protected]>
I just reapplied the TXT and CAA records - please let us know the result. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cduhn17 Can you please update the title and description to reflect the current state of this PR? Is everything looking good from your end or are there further changes needed? |
@dav3r , The certificates were created successfully. Thanks for your assistance and I will update the description to include the CAA record addition |
Update domain name for integration
🗣 Description
We need to add the integration domain name and issue letsencrypt ssl certificates. There is a need for both a TXT record and CAA record
💭 Motivation and context
There are no existing ACME certs
✅ Pre-approval checklist
to reflect the changes in this PR.