Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes issue #1990, upgrading react version part 1 #2025

Closed
wants to merge 32 commits into from

Conversation

ValeriaReveles
Copy link
Contributor

@ValeriaReveles ValeriaReveles commented Jul 6, 2023

Upgrade the current React version in Crossfeed to the latest version.

🗣 Description

Updated React packages, dependencies, and related peer dependencies.

💭 Motivation and context

The current version of React in 'frontend' is out of date which can lead to issues with future maintenance and operability of the Crossfeed site.

This PR updates all deprecated, out-of-date, and current dependencies, packages, and related peer dependencies in order to support the latest version of ReactJS library (v18). Issues with peer dependencies related to React needed to be upgraded and tested as some caused breaking changes. This PR fixes and closes issue #1990 part 1.

🧪 Testing

Tested updates and dependency changes to prevent breaking changes using 'ncu --doctor -u' and 'npm' tools to test and check for outdated packages. Additionally ran 'tests' to address fixes needed. Some code changes will be required on frontend files in order to fully support changes.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@ValeriaReveles ValeriaReveles linked an issue Jul 10, 2023 that may be closed by this pull request
@ValeriaReveles ValeriaReveles linked an issue Jul 14, 2023 that may be closed by this pull request
@ValeriaReveles ValeriaReveles temporarily deployed to production July 14, 2023 15:30 — with GitHub Actions Inactive
@ValeriaReveles ValeriaReveles temporarily deployed to staging July 14, 2023 15:30 — with GitHub Actions Inactive
@ValeriaReveles ValeriaReveles temporarily deployed to production July 14, 2023 15:50 — with GitHub Actions Inactive
@ValeriaReveles ValeriaReveles temporarily deployed to staging July 14, 2023 15:50 — with GitHub Actions Inactive
@ValeriaReveles ValeriaReveles temporarily deployed to production July 15, 2023 16:27 — with GitHub Actions Inactive
@ValeriaReveles ValeriaReveles temporarily deployed to staging July 15, 2023 16:27 — with GitHub Actions Inactive
@ValeriaReveles ValeriaReveles temporarily deployed to staging July 18, 2023 20:37 — with GitHub Actions Inactive
@ValeriaReveles ValeriaReveles temporarily deployed to production July 18, 2023 20:41 — with GitHub Actions Inactive
@ValeriaReveles ValeriaReveles temporarily deployed to staging July 18, 2023 20:41 — with GitHub Actions Inactive
@ValeriaReveles ValeriaReveles temporarily deployed to production July 18, 2023 21:17 — with GitHub Actions Inactive
@ValeriaReveles ValeriaReveles temporarily deployed to staging July 18, 2023 21:17 — with GitHub Actions Inactive
@ValeriaReveles ValeriaReveles added Frontend ASM-VDB User Interface Dependencies Pull requests that update a dependency file labels Jul 19, 2023
@ValeriaReveles ValeriaReveles removed the request for review from actualeyes July 19, 2023 13:51
@ValeriaReveles ValeriaReveles changed the title fixes issue #1990, upgrading react version fixes issue #1990, upgrading react version part 1 Jul 19, 2023
@ValeriaReveles ValeriaReveles temporarily deployed to production July 19, 2023 17:31 — with GitHub Actions Inactive
@actualeyes
Copy link
Contributor

The code here has already been deployed as a part of PR #2093

@actualeyes actualeyes closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file Frontend ASM-VDB User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade project to latest version of React part 1
3 participants