2117 vulnerability code 2023 07 24 7 8 10 and 11 #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actualeyes
approved these changes
Aug 4, 2023
epicfaace
reviewed
Aug 4, 2023
| const { chunkNumber, organizationId } = commandOptions; | ||
|
|
||
| // Sanitizes numChunks to protect against arbitrarily large numbers | ||
| const numChucksRawValue = commandOptions.numChunks; |
There was a problem hiding this comment.
@Matthew-Grayson moving forward, for future scans or future sanitization we might need to do, it might be good to refactor this code into a helper function (maybe parseCommandOptions) as opposed to copy and pasting it across different scans (as it's also here -- #2123).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #2114
🗣 Description
💭 Motivation and context
🧪 Testing
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist