Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-design of AuthLogin Page #2364

Merged
merged 56 commits into from
Jan 30, 2024
Merged

Conversation

courtneyc1
Copy link
Contributor

@courtneyc1 courtneyc1 commented Nov 1, 2023

🗣 Description

Re-design the AuthLogin Page. Completes issue #2323

💭 Motivation and context

Follow a given design layout to make the login page more user friendly.

🧪 Testing

The login page will have a new notification banner and messaging, redesigned warning banner, a footer with less fields, and overall layout change. A user will see the redesigned page rather than the old one.

📷 Screenshots

image Updated re-design as of 01/04/2024

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@courtneyc1 courtneyc1 linked an issue Nov 1, 2023 that may be closed by this pull request
2 tasks
@courtneyc1 courtneyc1 added the Frontend ASM-VDB User Interface label Nov 1, 2023
@courtneyc1 courtneyc1 self-assigned this Nov 1, 2023
@courtneyc1 courtneyc1 marked this pull request as draft November 2, 2023 15:07
@schmelz21 schmelz21 added Feature Enhancement Product Feature Enhancement: New or Improve, NOT Bug Story labels Nov 2, 2023
@courtneyc1
Copy link
Contributor Author

@dmfezzareed @schmelz21 I have made a few changes from the original design to help with the user experience. I have added the notifications above the login area and the Warning banner below with some stylistic changes. Please let me know your thoughts on the attached screen shots in accepting the new design or reverting the changes back to the original design.
login page
warning and footer

@schmelz21
Copy link
Collaborator

@courtneyc1 - as we review the suggestion, please note the footer change only needs to be applied to the login page only.

@schmelz21
Copy link
Collaborator

@courtneyc1 - it was determined to work toward the original design request, Thanks
https://user-images.githubusercontent.com/126171978/279734973-d56e81bd-a2eb-4556-a20c-e772ad21ad65.png

@dmfezzareed
Copy link

dmfezzareed commented Nov 8, 2023

@courtneyc1 I like the yellow background on the platform notification and the absence of a border; the footer looks great! @nickviola , @ameliav please note the footer for the new registration page.

@schmelz21 For the benefit of all frontend dev - The "landing strip" down the middle of any XFD page will be removed, and all pages refactored in MUI to utilize the landscape available. We want as much information displayed (as appropriate) on the first screen that loads, without scrolling being required, unless absolutely necessary. I've communicated this in the past . The rule will be no less than a 1 inch margin, on the left and right sides of any XFD page. cc @ameliav , @ValeriaReveles , @courtneyc1

  • Please stick with the acceptance criteria format as designed, changing/adding only the yellow platform notification formatting.

image

image

@dmfezzareed
Copy link

dmfezzareed commented Jan 4, 2024

Hello @schmelz21 @dmfezzareed ,

Typically, temporary notifications on web pages are a banner across the top to catch a user's attention. Are the "Platform Notifications" meant to be up for short periods of time? Else, if they are a permanent fixture to the page, they should go below the login box in a less eye-catching color as Debra had it. Please confirm.

image

@ameliav This suggestion is spot on! Kudos! So long as the banner across the top can be persistent for a period time, and visible at every logon page landing, I prefer your suggestion. cc @schmelz21

@ameliav ameliav self-assigned this Jan 4, 2024
@ameliav ameliav marked this pull request as ready for review January 4, 2024 20:29
Copy link
Contributor

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See one comment

Copy link
Collaborator

@schmelz21 schmelz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @cduhn17 - okay for a review and resolve conversation?

Copy link
Contributor

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ameliav ameliav merged commit aea1ea2 into master Jan 30, 2024
19 checks passed
@ameliav ameliav deleted the 2323-update-notification-with-new-messaging branch January 30, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Enhancement Product Feature Enhancement: New or Improve, NOT Bug Frontend ASM-VDB User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Login Page with new React MUI tools
6 participants