-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-design of AuthLogin Page #2364
Conversation
@dmfezzareed @schmelz21 I have made a few changes from the original design to help with the user experience. I have added the notifications above the login area and the Warning banner below with some stylistic changes. Please let me know your thoughts on the attached screen shots in accepting the new design or reverting the changes back to the original design. |
@courtneyc1 - as we review the suggestion, please note the footer change only needs to be applied to the login page only. |
@courtneyc1 - it was determined to work toward the original design request, Thanks |
@courtneyc1 I like the yellow background on the platform notification and the absence of a border; the footer looks great! @nickviola , @ameliav please note the footer for the new registration page. @schmelz21 For the benefit of all frontend dev - The "landing strip" down the middle of any XFD page will be removed, and all pages refactored in MUI to utilize the landscape available. We want as much information displayed (as appropriate) on the first screen that loads, without scrolling being required, unless absolutely necessary. I've communicated this in the past . The rule will be no less than a 1 inch margin, on the left and right sides of any XFD page. cc @ameliav , @ValeriaReveles , @courtneyc1
|
…/github.com/cisagov/crossfeed into 2323-update-notification-with-new-messaging
…/github.com/cisagov/crossfeed into 2323-update-notification-with-new-messaging
@ameliav This suggestion is spot on! Kudos! So long as the banner across the top can be persistent for a period time, and visible at every logon page landing, I prefer your suggestion. cc @schmelz21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See one comment
… shows up in Github
…/github.com/cisagov/crossfeed into 2323-update-notification-with-new-messaging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @cduhn17 - okay for a review and resolve conversation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🗣 Description
Re-design the AuthLogin Page. Completes issue #2323
💭 Motivation and context
Follow a given design layout to make the login page more user friendly.
🧪 Testing
The login page will have a new notification banner and messaging, redesigned warning banner, a footer with less fields, and overall layout change. A user will see the redesigned page rather than the old one.
📷 Screenshots
Updated re-design as of 01/04/2024✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist