Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CORS formatting. #2590

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Fix CORS formatting. #2590

merged 2 commits into from
Feb 29, 2024

Conversation

Matthew-Grayson
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson commented Feb 29, 2024 •
edited
Loading

🗣 Description

Changes allowed origin from array to single wildcard element.

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@Matthew-Grayson Matthew-Grayson linked an issue Feb 29, 2024 that may be closed by this pull request
Fix CORS Settings #2589
Closed
@Matthew-Grayson Matthew-Grayson marked this pull request as ready for review February 29, 2024 19:51
nickviola
nickviola approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ameliav
ameliav approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@ameliav ameliav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Matthew-Grayson Matthew-Grayson merged commit c94232d into master Feb 29, 2024
19 checks passed
@Matthew-Grayson Matthew-Grayson deleted the 2589-fix-cors-settings branch February 29, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameliav ameliav ameliav approved these changes

@nickviola nickviola nickviola approved these changes

@rapidray12 rapidray12 Awaiting requested review from rapidray12 rapidray12 is a code owner

@schmelz21 schmelz21 Awaiting requested review from schmelz21 schmelz21 is a code owner

@cduhn17 cduhn17 Awaiting requested review from cduhn17 cduhn17 is a code owner

@aloftus23 aloftus23 Awaiting requested review from aloftus23 aloftus23 is a code owner

Assignees

@Matthew-Grayson Matthew-Grayson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix CORS Settings
3 participants
@Matthew-Grayson @nickviola @ameliav