Skip to content

Commit

Permalink
Fixed footer behavior to stick to bottom of viewport
Browse files Browse the repository at this point in the history
This was only detectable on longer pages.  Expanding the footer made the page taller by expanding the footer below the bottom edge of the viewport.  Now we are using the sticky position to ensure that the footer is settled at the bottom.
  • Loading branch information
randywoods1 committed Sep 30, 2024
1 parent 3592c22 commit ba79b22
Show file tree
Hide file tree
Showing 8 changed files with 33 additions and 12 deletions.
31 changes: 26 additions & 5 deletions CSETWebNg/angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,14 @@
},
"configurations": {
"development": {
"optimization": true,
"optimization": {
"scripts": true,
"styles": {
"minify": true,
"inlineCritical": false
},
"fonts": true
},
"sourceMap": true,
"namedChunks": true,
"extractLicenses": true,
Expand All @@ -112,7 +119,14 @@
"maximumWarning": "400kb"
}
],
"optimization": true,
"optimization": {
"scripts": true,
"styles": {
"minify": true,
"inlineCritical": false
},
"fonts": true
},
"outputHashing": "all",
"sourceMap": false,
"namedChunks": false,
Expand All @@ -134,7 +148,14 @@
"maximumWarning": "6kb"
}
],
"optimization": true,
"optimization": {
"scripts": true,
"styles": {
"minify": true,
"inlineCritical": false
},
"fonts": true
},
"outputHashing": "all",
"sourceMap": false,
"namedChunks": false,
Expand Down Expand Up @@ -240,5 +261,5 @@
],
"cache": {
"enabled": false
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@


<!-- Footer -->
<div class="accordion" id="accordionFooter">
<div class="accordion sticky-footer" id="accordionFooter">
<div class="text-center">
<h4 class="accordion-header pb-1" id="headingOne">
<button id="footerExpanderButton" class="cset-footer-expand-button"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@


<!-- Footer -->
<div class="accordion" id="accordionFooter">
<div class="accordion sticky-footer" id="accordionFooter">
<div class="text-center">
<h4 class="accordion-header pb-1" id="headingOne">
<button id="footerExpanderButton" class="cset-footer-expand-button"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@


<!-- Footer -->
<div class="accordion" id="accordionFooter">
<div class="accordion sticky-footer" id="accordionFooter">
<div class="text-center">
<h4 class="accordion-header pb-1" id="headingOne">
<button id="footerExpanderButton" class="cset-footer-expand-button"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
</div>

<!-- Footer -->
<div class="accordion" id="accordionFooter">
<div class="accordion sticky-footer" id="accordionFooter">
<div class="text-center">
<h4 class="accordion-header pb-1" id="headingOne">
<button id="footerExpanderButton" class="cset-footer-expand-button"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@


<!-- Footer -->
<div class="accordion" id="accordionFooter">
<div class="accordion sticky-footer" id="accordionFooter">
<div class="text-center">
<h4 class="accordion-header pb-1" id="headingOne">
<button id="footerExpanderButton" class="cset-footer-expand-button"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@


<!-- Footer -->
<div class="accordion" id="accordionFooter">
<div class="accordion sticky-footer" id="accordionFooter">
<div class="text-center">
<h4 class="accordion-header pb-1" id="headingOne">
<button id="footerExpanderButton" class="cset-footer-expand-button"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@


<!-- Footer -->
<div class="accordion" id="accordionFooter">
<div class="accordion sticky-footer" id="accordionFooter">
<div class="text-center">
<h4 class="accordion-header pb-1" id="headingOne">
<button id="footerExpanderButton" class="cset-footer-expand-button"
Expand Down

0 comments on commit ba79b22

Please sign in to comment.