Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acet/date translation #3621

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Acet/date translation #3621

merged 6 commits into from
Nov 2, 2023

Conversation

mattrwins
Copy link
Contributor

@mattrwins mattrwins commented Nov 2, 2023

🗣 Description

  • Using moment-DateAdapter to translate the calendar date-selector on the NCUA assessment-detail page and the field date into the locale format.
  • Using moment.locale to translate the date on the my-assessments page based on Transloco's active language.
  • I'll go through reports and put the same date translation in those too.

Also, some miscellaneous transloco token translating.

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@randywoods randywoods merged commit 1f6ad8c into develop Nov 2, 2023
4 checks passed
@randywoods randywoods deleted the acet/date-translation branch November 2, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants