Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/acet spanish fixes #3637

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Bug/acet spanish fixes #3637

merged 2 commits into from
Nov 10, 2023

Conversation

mattrwins
Copy link
Contributor

🗣 Description

The Grouping names in the Spanish ACET Groupings.xlsx file used "and" in some places when it should've used '&'.

Also, made IRP-summary page reload when the user changes language.

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@MathesonBrett MathesonBrett merged commit f3235d8 into develop Nov 10, 2023
4 checks passed
@MathesonBrett MathesonBrett deleted the bug/acet-spanish-fixes branch November 10, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants