Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ngbAccordion package from app #4104

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

randywoods
Copy link
Collaborator

The only place it was "being used" is an ACET component with a commented-out footer. All the rest of the footers for the other skins has since been switched to use the Bootstrap 5 accordion. So if the ACET footer ever needs to come back, it will be rewritten anyway.

🗣 Description

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

The only place it was "being used" is an ACET component with a commented-out footer.  All the rest of the footers for the other skins has since been switched to use the Bootstrap 5 accordion.  So if the ACET footer ever needs to come back, it will be rewritten anyway.
@jekuipers jekuipers merged commit 57de9ca into develop Sep 19, 2024
2 checks passed
@jekuipers jekuipers deleted the remove-ng-accordion branch September 19, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants