Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed footer behavior to stick to bottom of viewport #4117

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

randywoods
Copy link
Collaborator

This was only detectable on longer pages. Expanding the footer made the page taller by expanding the footer below the bottom edge of the viewport. Now we are using the sticky position to ensure that the footer is settled at the bottom.

🗣 Description

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

This was only detectable on longer pages.  Expanding the footer made the page taller by expanding the footer below the bottom edge of the viewport.  Now we are using the sticky position to ensure that the footer is settled at the bottom.
@jekuipers jekuipers merged commit 1bbe7a5 into develop Sep 30, 2024
2 checks passed
@jekuipers jekuipers deleted the bug/footer-fix branch September 30, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants