Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n for module name on maturity questions screen #4210

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

randywoods
Copy link
Collaborator

🗣 Description

If a Transloco key is defined in the moduleBehaviors for a maturity model in the displayNameKey property, that value will be displayed instead of the internal "code" value of the model.

For example, instead of displaying "Practices - CMMC2F" we can display "Practices - Cybersecurity Maturity Model Certification (CMMC) 2.0". This value can be adjusted as needed in the transloco JSON file without affecting the internal name of the module.

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

The sub headers (blue boxes) match the domain headers 1-to-1, so we are hiding the domain headers to clean up the layout a bit
@LaddieZeigler LaddieZeigler merged commit b21358a into develop Nov 5, 2024
2 of 3 checks passed
@LaddieZeigler LaddieZeigler deleted the feature/CSET-2897 branch November 5, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants